perf: remove duplicate codes #39239

xiaoxiaojx · 2021-07-02T18:36:14Z

This line of code has been implemented in the prepareError function

// lib/_http_common.js

function prepareError(err, parser, rawPacket) {
  err.rawPacket = rawPacket || parser.getCurrentBuffer();
  if (typeof err.reason === 'string')
    err.message = `Parse Error: ${err.reason}`;
}

nodejs-github-bot · 2021-11-25T19:15:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/41116/

nodejs-github-bot · 2021-12-10T09:22:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/41439/

nodejs-github-bot · 2021-12-21T23:21:09Z

CI: https://ci.nodejs.org/job/node-test-pull-request/41603/

nodejs-github-bot · 2021-12-24T15:38:29Z

CI: https://ci.nodejs.org/job/node-test-pull-request/41648/

nodejs-github-bot · 2021-12-27T14:15:58Z

Commit Queue failed

- Loading data for nodejs/node/pull/39239 ✔ Done loading data for nodejs/node/pull/39239 ----------------------------------- PR info ------------------------------------ Title perf: remove duplicate codes (#39239) Author Shaw <784487301@qq.com> (@xiaoxiaojx, first-time contributor) Branch xiaoxiaojx:patch-1 -> nodejs:master Labels http, author ready Commits 1 - remove duplicate codes Committers 1 - kaiduo PR-URL: https://github.com/nodejs/node/pull/39239 Reviewed-By: Robert Nagy Reviewed-By: James M Snell Reviewed-By: Yongsheng Zhang ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/39239 Reviewed-By: Robert Nagy Reviewed-By: James M Snell Reviewed-By: Yongsheng Zhang -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 02 Jul 2021 18:36:14 GMT ✔ Approvals: 3 ✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/39239#pullrequestreview-698577770 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/39239#pullrequestreview-701561527 ✔ - Yongsheng Zhang (@ZYSzys): https://github.com/nodejs/node/pull/39239#pullrequestreview-829514403 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2021-12-24T15:38:29Z: https://ci.nodejs.org/job/node-test-pull-request/41648/ - Querying data for job/node-test-pull-request/41648/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD 9a85efaa7f..077c75beae master -> origin/master ✔ origin/master is now up-to-date master is out of sync with origin/master. Mismatched commits: - ba1b7a2749 tls: permit null as a pfx value - 077c75beae tls: permit null as a pfx value -------------------------------------------------------------------------------- HEAD is now at 077c75beae tls: permit null as a pfx value ✔ Reset to origin/master - Downloading patch for 39239 From https://github.com/nodejs/node * branch refs/pull/39239/merge -> FETCH_HEAD ✔ Fetched commits as 077c75beaecc..00342b335efa -------------------------------------------------------------------------------- [master 28ed5ff2f2] remove duplicate codes Author: Shaw <784487301@qq.com> Date: Sat Jul 3 02:33:35 2021 +0800 1 file changed, 1 deletion(-) ✔ Patches applied -------------------------------------------------------------------------------- --------------------------------- New Message ---------------------------------- remove duplicate codes

This line of code has been implemented in the prepareError function

PR-URL: #39239
Reviewed-By: Robert Nagy ronagy@icloud.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Yongsheng Zhang zyszys98@gmail.com

[master f511396186] remove duplicate codes
Author: Shaw 784487301@qq.com
Date: Sat Jul 3 02:33:35 2021 +0800
1 file changed, 1 deletion(-)
✖ f51139618623b3a56f2f5ea8c82518b1bf6e4886
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 3:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✖ 0:0 Missing subsystem. subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length

ℹ Please fix the commit message and try again.

https://github.com/nodejs/node/actions/runs/1627255427

This line of code has been implemented in the prepareError function. PR-URL: nodejs#39239 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

Trott · 2022-01-05T03:55:06Z

Landed in bad65ea.

Thanks for the contribution! 🎉

This line of code has been implemented in the prepareError function. PR-URL: nodejs#39239 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

This line of code has been implemented in the prepareError function. PR-URL: #39239 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

This line of code has been implemented in the prepareError function. PR-URL: nodejs#39239 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

This line of code has been implemented in the prepareError function. PR-URL: #39239 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

github-actions bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels Jul 2, 2021

This comment has been minimized.

Sign in to view

ronag approved these changes Jul 3, 2021

View reviewed changes

jasnell approved these changes Jul 8, 2021

View reviewed changes

This comment has been minimized.

Sign in to view

Ayase-252 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 7, 2021

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 7, 2021

This comment has been minimized.

Sign in to view

This was referenced Oct 8, 2021

CI Reliability 2021-10-08 nodejs/reliability#81

Open

CI Reliability 2021-10-09 nodejs/reliability#82

Open

This comment has been minimized.

Sign in to view

This was referenced Oct 10, 2021

CI Reliability 2021-10-10 nodejs/reliability#83

Open

CI Reliability 2021-10-11 nodejs/reliability#84

Open

Mesteery removed the needs-ci PRs that need a full CI run. label Oct 12, 2021

github-actions bot mentioned this pull request Oct 13, 2021

CI Reliability 2021-10-13 nodejs/reliability#85

Open

22 tasks

xiaoxiaojx force-pushed the patch-1 branch from 67a4c5e to 00342b3 Compare November 10, 2021 19:12

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2021

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2021

This comment has been minimized.

Sign in to view

Mesteery added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 25, 2021

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 25, 2021

This was referenced Nov 26, 2021

CI Reliability 2021-11-26 nodejs/reliability#129

Open

CI Reliability 2021-11-27 nodejs/reliability#130

Open

CI Reliability 2021-11-28 nodejs/reliability#131

Open

CI Reliability 2021-11-29 nodejs/reliability#132

Open

github-actions bot mentioned this pull request Dec 11, 2021

CI Reliability 2021-12-11 nodejs/reliability#141

Open

47 tasks

This was referenced Dec 20, 2021

CI Reliability 2021-12-20 nodejs/reliability#150

Open

CI Reliability 2021-12-21 nodejs/reliability#151

Open

This was referenced Dec 22, 2021

CI Reliability 2021-12-22 nodejs/reliability#152

Open

CI Reliability 2021-12-23 nodejs/reliability#153

Open

CI Reliability 2021-12-24 nodejs/reliability#154

Open

This was referenced Dec 25, 2021

CI Reliability 2021-12-25 nodejs/reliability#155

Open

CI Reliability 2021-12-26 nodejs/reliability#156

Open

CI Reliability 2021-12-27 nodejs/reliability#157

Open

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 27, 2021

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 27, 2021

This was referenced Dec 28, 2021

CI Reliability 2021-12-28 nodejs/reliability#158

Open

CI Reliability 2021-12-29 nodejs/reliability#159

Open

CI Reliability 2021-12-30 nodejs/reliability#160

Open

CI Reliability 2021-12-31 nodejs/reliability#161

Open

Trott force-pushed the patch-1 branch from 00342b3 to f9bb3e4 Compare January 5, 2022 03:54

http: remove duplicate code

bad65ea

This line of code has been implemented in the prepareError function. PR-URL: nodejs#39239 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

Trott force-pushed the patch-1 branch from f9bb3e4 to bad65ea Compare January 5, 2022 03:55

Trott merged commit bad65ea into nodejs:master Jan 5, 2022

targos mentioned this pull request Jan 16, 2022

v17.4.0 release proposal #41557

Merged

danielleadams mentioned this pull request Feb 1, 2022

v16.14.0 proposal #41804

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

perf: remove duplicate codes #39239

perf: remove duplicate codes #39239

xiaoxiaojx commented Jul 2, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

nodejs-github-bot commented Nov 25, 2021

nodejs-github-bot commented Dec 10, 2021

nodejs-github-bot commented Dec 21, 2021

nodejs-github-bot commented Dec 24, 2021

nodejs-github-bot commented Dec 27, 2021

PR-URL: #39239
Reviewed-By: Robert Nagy ronagy@icloud.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Yongsheng Zhang zyszys98@gmail.com

Trott commented Jan 5, 2022 •

edited

perf: remove duplicate codes #39239

perf: remove duplicate codes #39239

Conversation

xiaoxiaojx commented Jul 2, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

nodejs-github-bot commented Nov 25, 2021

nodejs-github-bot commented Dec 10, 2021

nodejs-github-bot commented Dec 21, 2021

nodejs-github-bot commented Dec 24, 2021

nodejs-github-bot commented Dec 27, 2021

PR-URL: #39239 Reviewed-By: Robert Nagy ronagy@icloud.com Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Yongsheng Zhang zyszys98@gmail.com

Trott commented Jan 5, 2022 • edited

PR-URL: #39239
Reviewed-By: Robert Nagy ronagy@icloud.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Yongsheng Zhang zyszys98@gmail.com

Trott commented Jan 5, 2022 •

edited